Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dlib: Update doc to use CommonMark #108919

Merged
merged 1 commit into from Apr 22, 2021
Merged

dlib: Update doc to use CommonMark #108919

merged 1 commit into from Apr 22, 2021

Conversation

bryanasdev000
Copy link
Member

Motivation for this change

Closes #105250.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bryanasdev000 bryanasdev000 mentioned this pull request Jan 10, 2021
Closed
@SuperSandro2000
Copy link
Member

@bryanasdev000 can you resolve the merge conflict?

@bryanasdev000
Copy link
Member Author

@bryanasdev000 can you resolve the merge conflict?

Done.

ryantm
ryantm requested changes Apr 1, 2021
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me! (I guess it has a merge conflict too now!)

doc/builders/packages/dlib.section.md Outdated Show resolved Hide resolved
doc/builders/packages/dlib.section.md Outdated Show resolved Hide resolved
@bryanasdev000
doc/builders/packages/dlib.xml: Convert to markdown
a1e28d3 
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
@bryanasdev000
Copy link
Member Author

@ryantm sorry for the delay, just did your changes and rebased to master.

@SuperSandro2000 SuperSandro2000 merged commit 9419ed6 into NixOS:master Apr 22, 2021
@bryanasdev000 bryanasdev000 deleted the doc-dlib branch May 3, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Dlib from Docbook to CommonMark
3 participants
@bryanasdev000 @SuperSandro2000 @ryantm