Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 85449b21bc05
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: b1d53b04eacf
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 9, 2021

  1. pythonPackages.demjson: fix tests, enable on Python 3.x 

    In commit 6ba044c, the demjson package was
disabled on Python 3.x with the comment that it doesn't seem to support any
Python 3.x versions.  But looking at the upstream repository, they do seem to
attempt to support Python 3 -- it turns out the failure on our end was caused by
some issue with trying to run `setup.py test` on a 2to3-using codebase with no
test suite (?).

In any case, this package's test suite doesn't seem to use the setuptools
mechanism, so in this commit I override the checkPhase to run the upstream tests
in the correct way.  This fixes the build on all Python versions.

EDIT 2021-01-08: rebased on top of PR #108378 which had explicitly disabled the
tests on all Python versions.
    @kini @bjornfor
    kini authored and bjornfor committed Jan 9, 2021
    Copy the full SHA
    b1d53b0 View commit details
    Browse the repository at this point in the history