Change: darken the background of all graph to increase contrast #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the current choice, colours like Mauve, Dark Green and Purple are nearly invisible in the graphs. Using a darker gradient resolves that issue.
|
This is just moving the issue around .. I don't like my own solution :D I need to think about this a bit more ... |
|
Going by the screenshots in #8539, changing the background to black should have the biggest impact. |
TrueBrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8539.
Motivation / Problem
Some company graph colours are very hard to read, making you want to change your company colour.
See #8539 for a detailed explanation.
Description
For the current choice, colours like Mauve, Dark Green and Purple
are nearly invisible in the graphs. Using a darker background
resolves that issue.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.