Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs.common-updater-scripts: update-source-version name singular #108841

Merged
merged 1 commit into from Jan 9, 2021

Conversation

urbas
Copy link
Contributor

@urbas urbas commented Jan 9, 2021

I believe this is a non-functional change (a typo fix in a script's help text).

Motivation for this change

To make the usage name of the script (as displayed in the usage help text) the same as the actual name of the installed script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar

@jtojnar
Copy link
Contributor

jtojnar commented Jan 9, 2021

Thanks.

@jtojnar jtojnar merged commit 1f93d9a into NixOS:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants