nixos-rebuild: Remove ambient systemctl dependency #108879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We wanted to use
nixos-rebuild --target-host
to deploy NixOS configurations from a flake to remote NixOS machines.However, this fails from both Darwin and non-systemd distros due to the code below which relies on an ambient systemctl being available:
As far as I could gather, the
NIX_REMOTE
environment variable is pretty much unnecessary nowadays (it's not even set in any of my environments, NixOS or otherwise) as nix uses other heuristics to determine whether to use the daemon or not. Simply removing this part seems to have resolved our issue without breaking anything else and this seems like a valid use-case.Things done
Remove aforementioned par
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @manveru