Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metasploit: 6.0.12 -> 6.0.25 #108878

Merged
merged 1 commit into from Jan 19, 2021
Merged

metasploit: 6.0.12 -> 6.0.25 #108878

merged 1 commit into from Jan 19, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 9, 2021 •
edited

Motivation for this change

Update to latest upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from makefu January 9, 2021 18:51
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108878 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • metasploit: log was empty

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108878 run on x86_64-darwin 1

1 package failed to build and are new build failure:
  • metasploit: log was empty

fails due to failing nokogiri

@SuperSandro2000 SuperSandro2000 changed the title metaspliot: 6.0.12 -> 6.0.25 metasploit: 6.0.12 -> 6.0.25 Jan 10, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 10, 2021 •
edited

I searched for that typo literally 5 minutes. Please fix the commit, too.

@SuperSandro2000
Copy link
Member

If nokogiri in #108924 is fixed we can merge this one.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 10, 2021
Closed
10 tasks
@fabaff
Copy link
Member Author

fabaff commented Jan 19, 2021

I searched for that typo literally 5 minutes. Please fix the commit, too.

Not kidding but I took me a while to see it as well.

@fabaff
Copy link
Member Author

fabaff commented Jan 19, 2021

Result of nixpkgs-review pr 108878 run on x86_64-linux 1

1 package built:
  • msf (metasploit)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108878 run on x86_64-linux 1

1 package built:
  • metasploit

@SuperSandro2000 SuperSandro2000 merged commit b2c6523 into NixOS:master Jan 19, 2021
@fabaff fabaff deleted the bump-msf branch January 19, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @SuperSandro2000