Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jc: 1.14.0 -> 1.14.1 #108856

Merged
merged 1 commit into from Jan 9, 2021
Merged

jc: 1.14.0 -> 1.14.1 #108856

merged 1 commit into from Jan 9, 2021

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jan 9, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Now running tests with pytestCheckHook because jc generates wrong unix
timestamps in test_last_F_ubuntu_20_4 test_last_wF_centos_7_7 otherwise.
};

propagatedBuildInputs = [ ruamel_yaml xmltodict pygments ];

checkInputs = [ pytestCheckHook ];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now running tests with pytestCheckHook because jc generates wrong unix
timestamps in test_last_F_ubuntu_20_4 test_last_wF_centos_7_7 otherwise.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108856 run on x86_64-linux 1

3 packages built:
  • jc (python38Packages.jc)
  • python37Packages.jc
  • python39Packages.jc

@Atemu Atemu deleted the update/jc branch January 10, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants