Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcem: init at 17 #108907

Merged
merged 2 commits into from Jan 12, 2021
Merged

pcem: init at 17 #108907

merged 2 commits into from Jan 12, 2021

Conversation

terinjokes
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the PR title and commit title to pcem: init at 17.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/misc/emulators/pcem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/pcem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/pcem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/pcem/default.nix Show resolved Hide resolved
pkgs/misc/emulators/pcem/default.nix Show resolved Hide resolved
pkgs/misc/emulators/pcem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/pcem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/pcem/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 changed the title pcem: init v17 pcem: init at 17 Jan 10, 2021
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit title to pcem: init at 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants