Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php80.extensions.oci8: 2.2.0 -> 3.0.1 #108904

Merged
merged 1 commit into from Jan 10, 2021
Merged

php80.extensions.oci8: 2.2.0 -> 3.0.1 #108904

merged 1 commit into from Jan 10, 2021

Conversation

aanderse
Copy link
Member

Motivation for this change

Version bump for php80.

https://pecl.php.net/package/oci8

Use 'pecl install oci8' to install for PHP 8.
Use 'pecl install oci8-2.2.0' to install for PHP 7.
Use 'pecl install oci8-2.0.12' to install for PHP 5.2 - PHP 5.6.
Use 'pecl install oci8-1.4.10' to install for PHP 4.3.9 - PHP 5.1.

@jtojnar even though not relevant for would you be willing to accept minor oci8 PRs for the fossar php repository, even though fossar doesn't care about oci8?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 10, 2021

Works for me as long as it builds or someone else is willing to fix it.

Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these changes, but just want to mention for @aanderse that @r-ryantm won't do automatic updates of the package as long as there's more than one sha/version in a file. So to get automatic updates you would need to split it to leaf files.

But that's up to you if you want to do that :)

@aanderse
Copy link
Member Author

The bot has never updated the package yet, it has always been me... so I'm ok with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants