enigma: init at 1.21 #108902
enigma: init at 1.21 #108902
Conversation
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
|
Can you please fetch from https://github.com/Enigma-Game/Enigma/releases ? |
|
Also please mark it broken on darwin for now. |
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package failed to build and are new build failure:
path should be ${gettext} |
|
Oh, awesome, I didn't realize that development of enigma has picked up again! I'll push a version bump (in a new commit, since I believe there is some value to having the older version available). For the new version, none of the earlier patches are required, but we do need a little bit of CPPFLAGS. I cannot test on darwin. Let's give the new version a try; if it doesn't work, then I'll mark it as broken. |
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package failed to build and are new build failure:
|
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
|
Yeah, now I can't merge it. Please revert the platform change and mark it broken on darwin. |
|
Seeing that darwin doesn't work out of the box with the new version either (and I having no access to a darwin machine to further debug this), I've restricted in a new force-push to |
|
Ah, I noticed your comment a bit too late. Will do so in a second! |
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
|
|
||
| postInstall = '' | ||
| rm -r $out/include | ||
| wrapProgram $out/bin/enigma --prefix PATH : "${stdenv.lib.makeBinPath [ xdg_utils ]}" |
There was a problem hiding this comment.
ofborg didn't catch this because it runs the outpaths checks in the PR's tree. Since this PR was old(er than the stdenv.lib trace commit), it didn't fail, but this is causing newer PRs (with the stdenv.lib trace commit) to fail.
There was a problem hiding this comment.
xdg_utils is an alias to xdg-utils -- fixed in #113869.
|
Oh, I'm sorry I didn't catch this, thank you for the post-merge surgery! |
Motivation for this change
enigma is a fun puzzle game available in Debian and Arch. This pull request adds it to nixpkgs.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)