Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibus: Update doc to use CommonMark #108921

Merged
merged 1 commit into from Mar 21, 2021
Merged

ibus: Update doc to use CommonMark #108921

merged 1 commit into from Mar 21, 2021

Conversation

bryanasdev000
Copy link
Member

@bryanasdev000 bryanasdev000 commented Jan 10, 2021 •
edited

Motivation for this change

Closes #105255.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bryanasdev000 bryanasdev000 mentioned this pull request Jan 10, 2021
Closed
@Mic92
Copy link
Member

Mic92 commented Feb 3, 2021

Could you have a look at the merge conflict?

@bryanasdev000
doc/builders/packages/ibus.xml: Convert to markdown
8bb00cf 
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
@bryanasdev000
Copy link
Member Author

Could you have a look at the merge conflict?

Sorry for the delay, just did a rebase.

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit faa9541 into NixOS:master Mar 21, 2021
@bryanasdev000 bryanasdev000 deleted the doc-ibus branch May 3, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Ibus from Docbook to CommonMark
3 participants
@bryanasdev000 @Mic92 @SuperSandro2000