Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for extending Dhall package set #108910

Merged
merged 1 commit into from Jan 10, 2021
Merged

Fix support for extending Dhall package set #108910

merged 1 commit into from Jan 10, 2021

Conversation

Gabriella439
Copy link
Contributor

  • Fix dhallPackages to be defined using callPackage instead of
    callPackages

    This enables the pkgs.dhallPackages.override method

  • Export pkgs.dhallPackages.callPackage

    This is also necessary in order to easily extend pkgs.dhallPackages with
    new packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gabriella439
Fix support for extending Dhall package set
fbd46be 
* Fix `dhallPackages` to be defined using `callPackage` instead of
  `callPackages`

  This enables the `pkgs.dhallPackages.override` method

* Export `pkgs.dhallPackages.callPackage`

  This is also necessary in order to easily extend `pkgs.dhallPackages` with
  new packages
@Gabriella439
Copy link
Contributor Author

cc: @ehmry

@ehmry ehmry merged commit 82425ca into NixOS:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gabriella439 @ehmry