botan2: add aarch64-linux to platforms #108892
Conversation
thelegy
changed the title
| @@ -46,7 +46,7 @@ stdenv.mkDerivation rec { | |||
| inherit version; | |||
| description = "Cryptographic algorithms library"; | |||
| maintainers = with maintainers; [ raskin ]; | |||
| platforms = ["x86_64-linux" "i686-linux" "x86_64-darwin"]; | |||
| platforms = ["aarch64-linux" "x86_64-linux" "i686-linux" "x86_64-darwin"]; | |||
There was a problem hiding this comment.
| platforms = ["aarch64-linux" "x86_64-linux" "i686-linux" "x86_64-darwin"]; | |
| platforms = platforms.linux ++ [ "x86_64-darwin"]; |
There was a problem hiding this comment.
That gives a list in a list, I guess you'd want something like:
platforms = platforms.linux ++ platforms.darwin;
(Or x86_64-darwin specifically if you believe it wouldn't build on macOS AArch64.).
Of course, you may as well use platforms.all then as well (do we really support anything else than Linux and Darwin currently?).
There was a problem hiding this comment.
It seems like platforms.unix was the previous value, but the explicit list has been used instead, because it would not build under aarch64. As it now does i don't see any reason to exclude anything more, than we must, so i would like to remove the explicit list.
Would the old value of platforms.unix be apropiate here, or should platforms.all be used here? platforms.linux ++ platforms.darwin seems a bit arbitrary to me.
There was a problem hiding this comment.
platforms.unix sounds sensible then 👍
|
Thanks aswell. |
Motivation for this change
I added the
aarch64-linuxplatform for the botan2 package, as I need it and it compiles and seems to work perfectly.Maybe we should open the paclage for even more platforms. I cannot tell because I don't know the original reason for allowing only so few platforms and if it still applies.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)