Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go, buildGo{Module,Package}: remove branch, disabled #108893

Merged
merged 3 commits into from Jan 10, 2021
Merged

go, buildGo{Module,Package}: remove branch, disabled #108893

merged 3 commits into from Jan 10, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 9, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
buildGo{Module,Package}: remove disabled
c6faa61 
This doesn't seem to have been used since pkgs/top-level/go-packages.nix was split up.
@zowoq
go: remove meta.branch
cf20350 
Only needed for `disabled` in `buildGo{Module,Package}`.
@zowoq zowoq merged commit 59db4d3 into NixOS:master Jan 10, 2021
@zowoq zowoq deleted the go-disabled branch January 10, 2021 20:00
@zowoq zowoq mentioned this pull request Jan 11, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @kalbasit @Mic92