New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.ds_store: init at 1.3.0 #108894
Conversation
Result of 3 packages built:
|
pkgs/top-level/python-packages.nix
Outdated
@@ -1890,6 +1890,8 @@ in { | |||
|
|||
dropbox = callPackage ../development/python-modules/dropbox { }; | |||
|
|||
ds_store = callPackage ../development/python-modules/ds_store { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please normalize the attribute name. According to the Python contributing guidelines, package names within nix should follow PEP 0503.
ds_store = callPackage ../development/python-modules/ds_store { }; | |
ds-store = callPackage ../development/python-modules/ds-store { }; |
The pname
can remain as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 7a3427d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- package name fits guidelines
- package version fits guidelines
- package build on (see python3Packages.ds_store: init at 1.3.0 #108894 (comment))
- [-] executables tested on ARCHITECTURE
- [-] all depending packages build
-
meta.description
is set and fits guidelines -
meta.license
fits upstream license -
meta.maintainers
is set - build time only dependencies are declared in
nativeBuildInputs
- source is fetched using the appropriate function
- phases are respected
- [-] patches that are remotely available are fetched with
fetchpatch
Otherwise, looks good to me.
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages built:
|
@GrahamcOfBorg build python3Packages.ds-store |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages built:
|
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)