Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ds_store: init at 1.3.0 #108894

Merged
merged 1 commit into from Jan 10, 2021
Merged

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 9, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 10, 2021

Result of nixpkgs-review pr 108894 1

3 packages built:
  • python37Packages.ds_store
  • python38Packages.ds_store
  • python39Packages.ds_store

@@ -1890,6 +1890,8 @@ in {

dropbox = callPackage ../development/python-modules/dropbox { };

ds_store = callPackage ../development/python-modules/ds_store { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please normalize the attribute name. According to the Python contributing guidelines, package names within nix should follow PEP 0503.

Suggested change
ds_store = callPackage ../development/python-modules/ds_store { };
ds-store = callPackage ../development/python-modules/ds-store { };

The pname can remain as-is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7a3427d

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package name fits guidelines
  • package version fits guidelines
  • package build on (see python3Packages.ds_store: init at 1.3.0 #108894 (comment))
  • [-] executables tested on ARCHITECTURE
  • [-] all depending packages build
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • [-] patches that are remotely available are fetched with fetchpatch

Otherwise, looks good to me.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108894 run on x86_64-linux 1

3 packages built:
  • python37Packages.ds_store
  • python38Packages.ds_store
  • python39Packages.ds_store

@prusnak
Copy link
Member Author

prusnak commented Jan 10, 2021

@GrahamcOfBorg build python3Packages.ds-store

@prusnak prusnak merged commit 0492b62 into NixOS:master Jan 10, 2021
@prusnak prusnak deleted the ds_store branch January 10, 2021 10:11
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108894 run on x86_64-darwin 1

3 packages built:
  • python37Packages.ds_store
  • python38Packages.ds_store
  • python39Packages.ds_store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants