Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom: 1.48.0 -> 1.53.0 #108915

Closed
wants to merge 1 commit into from
Closed

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Update to a newer version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 108915 run on x86_64-linux 1

2 packages built:
  • atom
  • atom-beta

atom runs fine, but atom-beta fails with:

nohup: failed to run command '/run/user/1000/atom-build/Atom/atom': No such file or directory

@SuperSandro2000

This comment has been minimized.

@MrMebelMan
Copy link
Contributor Author

@danieldk, I don't know how to fix atom-beta 😣

@taku0
Copy link
Contributor

taku0 commented Feb 13, 2021

The stable is now 1.54.0 and the beta is 1.55.0.

@ghost
Copy link

ghost commented Jun 10, 2021

This seems to be done in #114277

@ghost ghost closed this Jun 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants