Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerline-symbols: init at 2.8.1 #108916

Merged
merged 1 commit into from Jan 22, 2021
Merged

powerline-symbols: init at 2.8.1 #108916

merged 1 commit into from Jan 22, 2021

Conversation

midchildan
Copy link
Member

Motivation for this change

Add the powerline-symbols font. This is different from powerline-fonts, which is a collection of various patched fonts with powerline additions. This only includes the powerline symbols, and no patched fonts.

Result of nixpkgs-review
❯ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/nixpkgs 2032339e5bbce8a57655b8742190ecb32b7af863
Preparing worktree (detached HEAD 2032339e5bb)
Updating files: 100% (23852/23852), done.
HEAD is now at 2032339e5bb mmv-go: 0.1.2 -> 0.1.3
$ nix-env -f /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit e27f7903a1e43154dee15bd99016af633a017227
Updating 2032339e5bb..e27f7903a1e
Fast-forward
 pkgs/data/fonts/powerline-symbols/default.nix | 19 +++++++++++++++++++
 pkgs/top-level/all-packages.nix               |  2 ++
 2 files changed, 21 insertions(+)
 create mode 100644 pkgs/data/fonts/powerline-symbols/default.nix
$ nix-env -f /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/nixpkgs -qaP --xml --out-path --show-trace --meta
1 package added:
powerline-symbols (init at 2.8.1)

warning: ignoring the user-specified setting 'experimental-features', because it is a restricted setting and you are not a trusted user
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/build.nix
warning: ignoring the user-specified setting 'experimental-features', because it is a restricted setting and you are not a trusted user
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
1 package built:
powerline-symbols

warning: ignoring the user-specified setting 'experimental-features', because it is a restricted setting and you are not a trusted user
$ nix-shell /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/shell.nix
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@midchildan
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 11, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108916 run on x86_64-linux 1

1 package built:
  • powerline-symbols

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 15, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 18, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

1 similar comment
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 22, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@SuperSandro2000 SuperSandro2000 merged commit be3f605 into NixOS:master Jan 22, 2021
@midchildan midchildan deleted the powerline-symbols/init branch January 28, 2021 07:48
midchildan added a commit to midchildan/dotfiles that referenced this pull request Feb 4, 2021
@midchildan
chore(hm): remove upstreamed changes
22bb115 
NixOS/nixpkgs#108913, NixOS/nixpkgs#108916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@midchildan @SuperSandro2000