fira-code: only extract the variable font #108913
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fira Code includes a variable font file that packs all the variants in a single file. Including both variable and non-variable fonts would be redundant and cause the system to list the same font twice, as can be seen in the screenshot below:
I've also appended a package revision numberThis was a mistake._1
to the package name to invalidate the current package. Otherwise, the current package would continue to be used unchanged because it shares the same SHA256 hash.Result of nixpkgs-review
Retried after
nix-collect-garbage
. (The initial run complained about missing build logs probably due to the fact that it was already built)Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)