Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] i3-gaps: 4.18.2 -> 4.18.3 #108871

Merged
merged 1 commit into from Jan 14, 2021
Merged

[20.09] i3-gaps: 4.18.2 -> 4.18.3 #108871

merged 1 commit into from Jan 14, 2021

Conversation

thiagokokada
Copy link
Contributor

Motivation for this change

Should close issue #108624 (not tested though).

(cherry picked from commit 9190dab)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-ryantm @thiagokokada
i3-gaps: 4.18.2 -> 4.18.3
e81ecad 
(cherry picked from commit 9190dab)
@thiagokokada thiagokokada mentioned this pull request Jan 9, 2021
Closed
@thiagokokada thiagokokada changed the title i3-gaps: 4.18.2 -> 4.18.3 [20.09] i3-gaps: 4.18.2 -> 4.18.3 Jan 9, 2021
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 108871 run on x86_64-linux 1

1 package built:
  • i3-gaps

@ofborg ofborg bot requested a review from fmthoma January 9, 2021 17:42
@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 9, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 9, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from timokau January 13, 2021 21:22
timokau
timokau approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog confirms that this is a good candidate for backport. The release fixes a single bug and is very unlikely to cause any regressions.

Thank you @thiagokokada!

@timokau timokau merged commit f6a7af4 into NixOS:release-20.09 Jan 14, 2021
@thiagokokada thiagokokada deleted the backport-i3-gaps branch January 14, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@fmthoma fmthoma Awaiting requested review from fmthoma

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiagokokada @timokau @r-ryantm