Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libstrangle: 2017-02-22 -> 0.1.1 #108869

Merged
merged 1 commit into from Mar 21, 2021
Merged

libstrangle: 2017-02-22 -> 0.1.1 #108869

merged 1 commit into from Mar 21, 2021

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Jan 9, 2021

Motivation for this change

Package update. Adds Vulkan support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Jan 9, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change the following:

    meta.homepage = "https://gitlab.com/torkel104/libstrangle";

pkgs/tools/X11/libstrangle/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/libstrangle/default.nix Outdated Show resolved Hide resolved
@prusnak
Copy link
Member

prusnak commented Jan 9, 2021

@GrahamcOfBorg build libstrangle

prusnak
prusnak approved these changes Jan 9, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the .nix file ACK

For changes in nixos.patch I am paging @aske (maintainer of the package)

@prusnak prusnak requested a review from aske January 9, 2021 17:31
@jakobrs
Copy link
Contributor Author

jakobrs commented Feb 12, 2021

Anything I can do to get this merged?

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 2a78603 into NixOS:master Mar 21, 2021
@jakobrs jakobrs deleted the libstrangle branch March 21, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@aske aske Awaiting requested review from aske

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakobrs @prusnak @SuperSandro2000