Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blobwars: init at 2.00 #108884

Merged
merged 1 commit into from Feb 17, 2021
Merged

blobwars: init at 2.00 #108884

merged 1 commit into from Feb 17, 2021

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Jan 9, 2021

Motivation for this change

Blobwars is an old and neat platform game available in Debian and Arch. This pull request adds blobwars to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iblech iblech force-pushed the patch-blobwars branch 2 times, most recently from 42b38de to b460c5c Compare January 9, 2021 20:39
pkgs/games/blobwars/default.nix Outdated Show resolved Hide resolved
pkgs/games/blobwars/default.nix Outdated Show resolved Hide resolved
pkgs/games/blobwars/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108884 run on x86_64-linux 1

1 package built:
  • blobwars

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108884 run on x86_64-linux 1

1 package built:
  • blobwars

@iblech
Copy link
Contributor Author

iblech commented Feb 14, 2021

I just force-pushed to resolve the merge conflict.

pkgs/games/blobwars/default.nix Outdated Show resolved Hide resolved
pkgs/games/blobwars/default.nix Outdated Show resolved Hide resolved
@iblech
Copy link
Contributor Author

iblech commented Feb 15, 2021

Thank you for the new review, @SuperSandro2000! :-)

@SuperSandro2000 SuperSandro2000 merged commit 3329658 into NixOS:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants