Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rakudo: 2020.11 -> 2020.12 #107243

Merged
merged 3 commits into from Dec 21, 2020
Merged

rakudo: 2020.11 -> 2020.12 #107243

merged 3 commits into from Dec 21, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Dec 20, 2020

Motivation for this change

https://github.com/rakudo/rakudo/blob/2020.12/docs/ChangeLog

dependencies:
nqp: 2020.11 -> 2020.12
moarvm: 2020.11 -> 2020.12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • moarvm
  • nqp
  • rakudo
  • zef

@stigtsp
Copy link
Member Author

stigtsp commented Dec 20, 2020

@GrahamcOfBorg build rakudo

danieldk
danieldk approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some example programs work as expected.

Result of nixpkgs-review pr 107243 run on x86_64-linux 1

4 packages built:
  • moarvm
  • nqp
  • rakudo
  • zef

@danieldk danieldk merged commit 5ba85d6 into NixOS:master Dec 21, 2020
@ghost
Copy link

ghost commented Feb 15, 2021

Any chance to see rakudo-packages.nix ?

@stigtsp
Copy link
Member Author

stigtsp commented Feb 15, 2021 •
edited

Any chance to see rakudo-packages.nix ?

Yeah that would be nice, I did make some efforts on this here but didn't get around to finishing it, there is also another effort here https://github.com/chloekek/raku-nix

@ghost
Copy link

ghost commented Feb 19, 2021

Besides "nixfy everything" approach, there is a weird issue about https://github.com/ugexe/Perl6-ecosystems repo lags behind rakudo progress.
Many libraries are for older rakudo.

rakudo-packages.nix can make a compatibility matrix of "rakudo-XXXX.XX and its packages"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @danieldk