Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ppxlib: add ppxlib 0.20.0 #107248

Closed
wants to merge 1 commit into from
Closed

ocamlPackages.ppxlib: add ppxlib 0.20.0 #107248

wants to merge 1 commit into from

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Add latest version of ppxlib to ocamlPackages, leave default ppxlib version untouched.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Dec 26, 2020

What’s the motivation for this addition? Isn’t an update more adequate?

@sternenseemann
Copy link
Member Author

Originally I thought that adding another version is necessary for cstruct 6.0.0 which depends on ppxlib >= 0.16.0, but you are right, an update needs to be attempted instead: If ppx_sexp_conv and ppx_cstruct depend on different ppxlib versions the ppx_cstruct build fails unfortunately.

@sternenseemann
Copy link
Member Author

From my testing updating ppxlib to 0.16.0 doesn't even work, the problem is the differing versions of ocaml-migrate-parsetree being propagated in that case. Updating ocaml-migrate-parsetree to 2.1.0 doesn't seem feasible at the moment as well.

I'm not sure how to proceed here, maybe we just have to wait for wider adoption of ocaml-migrate-parsetree 2.1.0.

@sternenseemann
Copy link
Member Author

0.20.0 doesn't seem to be the way to go right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl