Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethminer: fix broken package by switching to clang #107239

Merged
merged 1 commit into from Dec 21, 2020
Merged

ethminer: fix broken package by switching to clang #107239

merged 1 commit into from Dec 21, 2020

Conversation

breakds
Copy link
Contributor

@breakds breakds commented Dec 20, 2020 •
edited

Motivation for this change

The ethminer has been broken due to the reason that both gcc 8/9 cannot compile it. This PR updated the package to use clang (7.1) instead. Tested locally (NixOS) that the package is successfully built and also tested mining with it smoothly (see below)

$ result/bin/ethminer --farm-recheck 200 -U -P stratum://${WALLET_ADDRESS}.Worker@us1.ethermine.org:4444

ethminer 0.18.0
Build: linux/release/clang

 i 22:24:53 .ethminer-wrapp Configured pool us1.ethermine.org:4444
 i 22:24:53 .ethminer-wrapp Selected pool us1.ethermine.org:4444
 i 22:24:53 .ethminer-wrapp Negotiation of EthereumStratum/2.0.0 failed. Trying another ...
 i 22:24:53 .ethminer-wrapp Stratum mode : EthereumStratum/1.0.0 (NiceHash)
 i 22:24:53 .ethminer-wrapp Established connection to us1.ethermine.org [172.65.218.238:4444]
 i 22:24:53 .ethminer-wrapp Spinning up miners...
cu 22:24:53 cuda-0   Using Pci Id : 0d:00.0 GeForce GTX 1080 Ti (Compute 6.1) Memory : 10.91 GB
 i 22:24:53 .ethminer-wrapp Authorized worker 0x5c2816Cd036B29dA9Ba03E0D7c4BEDBbEAA671eA.Worker
 i 22:24:53 .ethminer-wrapp Epoch : 382 Difficulty : 4.29 Gh
 i 22:24:53 .ethminer-wrapp Job: 3d2fcd45… us1.ethermine.org [172.65.218.238:4444]
 i 22:24:55 .ethminer-wrapp Job: 740a5c54… us1.ethermine.org [172.65.218.238:4444]
cu 22:24:55 cuda-0   Generating DAG + Light : 4.05 GB
 i 22:24:55 .ethminer-wrapp Job: 8d14a775… us1.ethermine.org [172.65.218.238:4444]
 m 22:24:58 .ethminer-wrapp 0:00 A0 0.00 h - cu0 0.00
 i 22:24:59 .ethminer-wrapp Job: 158f0d2e… us1.ethermine.org [172.65.218.238:4444]
 i 22:25:03 .ethminer-wrapp Job: f75b49d3… us1.ethermine.org [172.65.218.238:4444]
 m 22:25:03 .ethminer-wrapp 0:00 A0 0.00 h - cu0 0.00
cu 22:25:06 cuda-0   Generated DAG + Light in 11,570 ms. 6.86 GB left.
 i 22:25:07 .ethminer-wrapp Job: c2c26957… us1.ethermine.org [172.65.218.238:4444]
 m 22:25:08 .ethminer-wrapp 0:00 A0 157.09 Kh - cu0 157.09
 i 22:25:11 .ethminer-wrapp Job: 5d9d572a… us1.ethermine.org [172.65.218.238:4444]
 m 22:25:13 .ethminer-wrapp 0:00 A0 32.16 Mh - cu0 32.16
 i 22:25:15 .ethminer-wrapp Job: 3a7bb902… us1.ethermine.org [172.65.218.238:4444]
 i 22:25:17 .ethminer-wrapp Job: 07c29244… us1.ethermine.org [172.65.218.238:4444]
 m 22:25:18 .ethminer-wrapp 0:00 A0 32.21 Mh - cu0 32.21
 i 22:25:19 .ethminer-wrapp Job: 9af3ecc6… us1.ethermine.org [172.65.218.238:4444]
 i 22:25:19 .ethminer-wrapp Job: 3f30f793… us1.ethermine.org [172.65.218.238:4444]
 m 22:25:23 .ethminer-wrapp 0:00 A0 32.20 Mh - cu0 32.20
 i 22:25:23 .ethminer-wrapp Job: 7d7f724d… us1.ethermine.org [172.65.218.238:4444]
 i 22:25:27 .ethminer-wrapp Job: 346888a1… us1.ethermine.org [172.65.218.238:4444]
 m 22:25:28 .ethminer-wrapp 0:00 A0 32.19 Mh - cu0 32.19
 i 22:25:29 .ethminer-wrapp Job: 09005484… us1.ethermine.org [172.65.218.238:4444]
 i 22:25:29 .ethminer-wrapp Job: 56516961… us1.ethermine.org [172.65.218.238:4444]
 m 22:25:33 .ethminer-wrapp 0:00 A0 32.18 Mh - cu0 32.18
...
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 107239 run on x86_64-linux 1

1 package built:
  • ethminer

@jonringer jonringer merged commit 0446b8a into NixOS:master Dec 21, 2020
@breakds
Copy link
Contributor Author

breakds commented Dec 21, 2020

LGTM

Result of nixpkgs-review pr 107239 run on x86_64-linux 1

1 package built:

Thanks for the review!

@wheelsandmetal wheelsandmetal mentioned this pull request Mar 10, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@breakds @jonringer