Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

umockdev: 0.15.2 -> 0.15.4 #108317

Merged
merged 1 commit into from Jan 3, 2021
Merged

umockdev: 0.15.2 -> 0.15.4 #108317

merged 1 commit into from Jan 3, 2021

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 3, 2021

Motivation for this change

Build umockdev again, with tests enabled, as they now succeed again. Remove some leftover unused patches.
Will update to fetch once a release is made,

cc @martinpitt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli mentioned this pull request Jan 3, 2021
Closed
@martinpitt
Copy link

This looks pleasantly green! 💚 As that seems to be by and large okay now, I did a new
0.15.4 upstream release, so you can change that back to an official tarball. Nice to see the cleanups!

This is now running in CI, so it should not break again. Thanks @flokli for your help!

@flokli flokli marked this pull request as ready for review January 3, 2021 20:53
@flokli flokli changed the title WIP: umockdev: 0.15.2 -> 0.15.4 (?) umockdev: 0.15.2 -> 0.15.4 Jan 3, 2021
@flokli
Copy link
Contributor Author

flokli commented Jan 3, 2021

I pointed this to the officially released tarball.

@lovesegfault lovesegfault merged commit d14652c into NixOS:master Jan 3, 2021
@martinpitt martinpitt mentioned this pull request Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @martinpitt @lovesegfault