Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bing back pull request #107032 from cpcloud/nomad-nvml #108339

Closed
wants to merge 1 commit into from
Closed

Bing back pull request #107032 from cpcloud/nomad-nvml #108339

wants to merge 1 commit into from

Conversation

SuperSandro2000
Copy link
Member

This reverts commit 6c9b507.

Motivation for this change

This brings back the reverted PR from #107032.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from endocrimes and rushmorem January 3, 2021 18:59
@cpcloud
Copy link
Contributor

cpcloud commented Jan 3, 2021

@SuperSandro2000 Should I close #108341?

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 Should I close #108341?

Nah. I close this one because I don't want to address review feedback about this.

@SuperSandro2000 SuperSandro2000 deleted the bring-back branch January 3, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes Awaiting requested review from endocrimes

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @cpcloud