Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/shadow: add switch user subtest #108314

Merged
merged 1 commit into from Jan 3, 2021
Merged

nixos/tests/shadow: add switch user subtest #108314

merged 1 commit into from Jan 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 3, 2021

Motivation for this change

#108313

This is a failing test and this is intended. To confirm this test succeeds when the bug is not present:

$ git checkout b0587cfbd1d6ec5730032891712ea260c177ab4f # one before the staging merge
$ git checkout 74aa934c7619bed649086ff4b781d7fb645f144d nixos/tests/shadow.nix
$ nix-build nixos/tests/shadow.nix
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from NeQuissimus January 3, 2021 12:57
@ofborg ofborg bot added the 6.topic: nixos label Jan 3, 2021
@ghost ghost requested a review from FRidh January 3, 2021 13:02
@FRidh FRidh merged commit 12f3e2c into NixOS:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant