Skip to content

youtube-dl: 2020.12.31 -> 2021.01.03 #108281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2021
Merged

youtube-dl: 2020.12.31 -> 2021.01.03 #108281

merged 1 commit into from
Jan 3, 2021
+2 −2

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 3, 2021

https://github.com/ytdl-org/youtube-dl/releases/tag/2021.01.03

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@zowoq zowoq added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 3, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jan 3, 2021
@zowoq zowoq merged commit 907e950 into NixOS:master Jan 3, 2021
@zowoq zowoq deleted the ytdl branch January 3, 2021 12:41
@zowoq
Copy link
Contributor Author

zowoq commented Jan 3, 2021

20.09: 78a5623

@zowoq zowoq added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 3, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108281 run on x86_64-darwin 1

5 packages marked as broken and skipped:
  • haskellPackages.cut-the-crap
  • jellyfin-mpv-shim
  • kodi-cli
  • persepolis
  • sublime-music
1 package failed to build and are new build failure:
  • mpc-qt: log https://hastebin.com/raw/xoqodegaxe
21 packages built:
  • catt
  • curseradio
  • mkchromecast
  • mopidy-youtube
  • mps-youtube
  • plex-mpv-shim
  • python37Packages.mpv
  • python37Packages.pafy
  • python37Packages.youtube-dl
  • python37Packages.youtube-dl-light
  • python38Packages.mpv
  • python38Packages.pafy
  • youtube-dl (python38Packages.youtube-dl)
  • youtube-dl-light (python38Packages.youtube-dl-light)
  • python39Packages.mpv
  • python39Packages.pafy
  • python39Packages.youtube-dl
  • python39Packages.youtube-dl-light
  • somafm-cli
  • tuijam
  • ytcc

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

plex-mpv-shim:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108281 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • plex-media-player: log was empty
34 packages built:
  • catt
  • celluloid
  • curseradio
  • haskellPackages.cut-the-crap
  • jellyfin-mpv-shim
  • jftui
  • kodi-cli
  • lollypop
  • minitube
  • mkchromecast
  • mopidy-youtube
  • mpc-qt
  • mps-youtube
  • mpv
  • persepolis
  • plex-mpv-shim
  • python37Packages.mpv
  • python37Packages.pafy
  • python37Packages.youtube-dl
  • python37Packages.youtube-dl-light
  • python38Packages.mpv
  • python38Packages.pafy
  • youtube-dl (python38Packages.youtube-dl)
  • youtube-dl-light (python38Packages.youtube-dl-light)
  • python39Packages.mpv
  • python39Packages.pafy
  • python39Packages.youtube-dl
  • python39Packages.youtube-dl-light
  • qimgv
  • somafm-cli
  • sublime-music
  • tartube
  • tuijam
  • ytcc

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

jellyfin-mpv-shim:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
plex-mpv-shim:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
sublime-music:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member

Fixed all those issues and going to do a PR with them tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak

@fabaff fabaff

@Phreedom Phreedom

@Enzime Enzime

@AndersonTorres AndersonTorres

@fpletz fpletz

@Ma27 Ma27

@bluescreen303 bluescreen303

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @SuperSandro2000 @prusnak @fabaff