Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clojure-lsp: 20201228T020543 -> 2021.01.03-00.42.23 #108328

Merged
merged 1 commit into from Jan 6, 2021
Merged

clojure-lsp: 20201228T020543 -> 2021.01.03-00.42.23 #108328

merged 1 commit into from Jan 6, 2021

Conversation

ericdallo
Copy link
Member

@ericdallo ericdallo commented Jan 3, 2021 •
edited

Motivation for this change
  • Fix clojure-lsp that is broken ATM passing JVM args as the program args
  • Bump to the latest version following its new version pattern
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 108328 1

1 package built:
  • clojure-lsp

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/326

@ericdallo ericdallo self-assigned this Jan 5, 2021
@ericdallo
Copy link
Member Author

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 5, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 5, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ericdallo
Copy link
Member Author

/status needs_reviewer

@thiagokokada
Copy link
Contributor

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau January 5, 2021 13:28
timokau
timokau approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit 3138165 into NixOS:master Jan 6, 2021
@ericdallo ericdallo deleted the bump-clojure-lsp branch January 6, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@timokau timokau timokau approved these changes

Assignees

@ericdallo ericdallo

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericdallo @thiagokokada @nixos-discourse @timokau