Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch pffft from upstream project website instead of bitbucket #108287

Merged
merged 1 commit into from Jan 3, 2021
Merged

Fetch pffft from upstream project website instead of bitbucket #108287

merged 1 commit into from Jan 3, 2021

Conversation

jpotier
Copy link
Contributor

@jpotier jpotier commented Jan 3, 2021 •
edited

Starting from this commit
VCVRack/Rack@2db08f1
the upstream project does not expect to use bitbucket anymore. The title
mentions that “BitBucket deleted all Mercurial repos”. Instead, an archive of
the pffft source is hosted on vcvrack.com directly. The unziped sha256 is the
same as before this change.

Motivation for this change

#107580

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jpotier
Copy link
Contributor Author

jpotier commented Jan 3, 2021

We also have the option of pulling the archive from bitbucket still. But, as the source of vcvrack itself uses vcvrack.com, I'm thinking this will be looked at closer by upstream, than bitbucket.

@jpotier
Copy link
Contributor Author

jpotier commented Jan 3, 2021

@ddelabru if you want to have a look as well

@jpotier jpotier requested a review from Moredread January 3, 2021 07:10
SuperSandro2000
SuperSandro2000 reviewed Jan 3, 2021
View reviewed changes
pkgs/applications/audio/vcv-rack/default.nix
repo = "pffft";
rev = "74d7261be17cf659d5930d4830609406bd7553e3";
pfft-source = fetchzip {
url = "https://vcvrack.com/downloads/dep/pffft.zip";
sha256 = "084csgqa6f1a270bhybjayrh3mpyi2jimc87qkdgsqcp8ycsx1l1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you double check if this hash changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unpacked hash has probably not changed (calling :b vcv-rack in nix repl used my cached /nix/store version)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put in whatever URL you want and the hash is not invalidated. The only way I know to test this is to change the hash and test of the old one is still generated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the hash first (I'm aware of this behavior). Here's what I did:

  • change the hash to "0000...00" (same length)
  • nix repl -I nixpkgs=. '<nixpkgs>'
  • invoke :b vcv-rack
  • Get the hash from failure message, and update the source
  • in the repl :r
  • then :b vcv-rack
  • this gave me back a cached build path

Copy link
Member

@prusnak prusnak Jan 3, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ nix-prefetch-url --unpack https://vcvrack.com/downloads/dep/pffft.zip
...
084csgqa6f1a270bhybjayrh3mpyi2jimc87qkdgsqcp8ycsx1l1

👍

prusnak
prusnak reviewed Jan 3, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the commit message to:

vcv-rack: fetch pffft from upstream project website instead of bitbucket

@jpotier
vcv-rack: fetch pffft from upstream project website instead of bitbucket
7964c98 
Starting from this commit
VCVRack/Rack@2db08f1
the upstream project does not expect to use bitbucket anymore. The title
mentions that “BitBucket deleted all Mercurial repos”. Instead, an archive of
the pffft source is hosted on vcvrack.com directly. The unziped sha256 is the
same as before this change.
@jpotier jpotier requested a review from prusnak January 3, 2021 13:06
@prusnak
Copy link
Member

prusnak commented Jan 3, 2021

@GrahamcOfBorg build vcv-rack

@prusnak prusnak merged commit b33fd9a into NixOS:master Jan 3, 2021
@jpotier jpotier deleted the fix-vcv-rack-bitbucket branch January 4, 2021 06:25
@Ralith
Copy link
Contributor

Ralith commented May 22, 2021 •
edited

Should this be backported to stable? vcv-rack installs there currently 404ing trying to fetch https://bitbucket.org/jpommier/pffft/get/29e4f76ac53bef048938754f32231d7836401f79.tar.gz

@Moredread Moredread mentioned this pull request May 28, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moredread Moredread Awaiting requested review from Moredread

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpotier @prusnak @Ralith @SuperSandro2000