Skip to content

zdoom: refactor #108299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2021
Merged

zdoom: refactor #108299

merged 2 commits into from
Jan 4, 2021
+9 −11

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 3, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

SuperSandro2000
SuperSandro2000 approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@aanderse
Copy link
Member

aanderse commented Jan 3, 2021

@GrahamcOfBorg eval

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 3, 2021
@ofborg ofborg bot requested a review from Lassulus January 3, 2021 19:33
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108299 run on x86_64-linux 1

2 packages built:
  • zdbsp
  • zdoom

Lassulus
Lassulus reviewed Jan 4, 2021
View reviewed changes
@siraben
zdoom: refactor

Verified

This commit was signed with the committer’s verified signature.
rickie Rick Ossendrijver
GPG key ID: A2237828CE7F76B2
Verified
Learn about vigilant mode
c602076
@ofborg ofborg bot requested a review from Lassulus January 4, 2021 09:53
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108299 run on x86_64-darwin 1

1 package built:
  • zdbsp

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108299 run on x86_64-linux 1

2 packages built:
  • zdbsp
  • zdoom

@SuperSandro2000 SuperSandro2000 merged commit 217285c into NixOS:master Jan 4, 2021
@siraben siraben deleted the zdbsp-platform branch January 4, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@aanderse aanderse

@Lassulus Lassulus

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siraben @aanderse @SuperSandro2000 @Lassulus