Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove enableParallelBuilding = true if using cmake #108300

Merged
merged 1 commit into from Jan 3, 2021
Merged

treewide: remove enableParallelBuilding = true if using cmake #108300

merged 1 commit into from Jan 3, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 3, 2021 •
edited

Motivation for this change

cmake in nativeBuildInputs already sets enableParallelBuilding to true.

Checked files

$ ag -l "cmake" | xargs ag -l "enableParallelBuilding = true" > check.txt && wc -l check.txt
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben requested a review from teto as a code owner January 3, 2021 10:03
@siraben siraben changed the base branch from master to staging January 3, 2021 10:04
@ofborg ofborg bot added the 6.topic: xfce The Xfce Desktop Environment label Jan 3, 2021
@siraben siraben force-pushed the parallel-cmake branch 2 times, most recently from 4c79d7c to 1fb2fd0 Compare January 3, 2021 10:37
@siraben
Copy link
Member Author

siraben commented Jan 3, 2021

I did not expect such a mass rebuild.

@siraben siraben force-pushed the parallel-cmake branch 2 times, most recently from 87ffe3f to 074b5c0 Compare January 3, 2021 11:35
@Ericson2314 Ericson2314 merged commit b03fdcc into NixOS:staging Jan 3, 2021
@siraben siraben deleted the parallel-cmake branch January 4, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 is a code owner

Assignees
No one assigned
Labels
6.topic: python 6.topic: qt/kde 6.topic: xfce The Xfce Desktop Environment 8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @Ericson2314