Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.certifi: 2020.11.8 -> 2020.12.5 #108297

Merged
merged 1 commit into from Jan 4, 2021
Merged

python3Packages.certifi: 2020.11.8 -> 2020.12.5 #108297

merged 1 commit into from Jan 4, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 3, 2021 •
edited

Motivation for this change

Update to latest upstream release 2020.12.5

Commit log: https://github.com/certifi/python-certifi/commits/master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Jan 3, 2021

@GrahamcOfBorg build python3Packages.certifi

@prusnak
Copy link
Member

prusnak commented Jan 3, 2021

@GrahamcOfBorg eval

@prusnak
Copy link
Member

prusnak commented Jan 3, 2021

/rebase_staging

@SuperSandro2000
Copy link
Member

/rebase-staging

@github-actions github-actions bot changed the base branch from master to staging January 3, 2021 18:55
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108297 run on x86_64-linux 1

1 package built:
  • python38Packages.certifi

@SuperSandro2000 SuperSandro2000 merged commit b6af78f into NixOS:staging Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @prusnak @SuperSandro2000