Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stegseek: init at 0.5 #108298

Merged
merged 1 commit into from Jan 5, 2021
Merged

stegseek: init at 0.5 #108298

merged 1 commit into from Jan 5, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 3, 2021

Motivation for this change

Stegseek is a lightning fast steghide cracker that can be
used to extract hidden data from files.

https://github.com/RickdeJager/stegseek

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Emantor
Emantor approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • builds
  • license correct
  • binary works as far as outputting the help section

@fabaff
Copy link
Member Author

fabaff commented Jan 3, 2021

Thanks for the review, @Emantor.

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108298 run on x86_64-linux 1

1 package built:
  • stegseek

@SuperSandro2000 SuperSandro2000 merged commit 34b66c5 into NixOS:master Jan 5, 2021
@fabaff fabaff deleted the stegseek branch January 7, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @Emantor