Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.micawber: 0.5.1 -> 0.5.2 #108361

Merged
merged 1 commit into from Jan 4, 2021

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jan 3, 2021

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python37Packages.micawber is: "A small library for extracting rich content from urls"

meta.homepage for python37Packages.micawber is: "https://micawber.readthedocs.io/en/latest/"

meta.changelog for python37Packages.micawber is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
python37Packages.micawber
python38Packages.micawber
python39Packages.micawber
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/5c81adaq04jlfiii1rda3pay67j0fh4d-python3.7-micawber-0.5.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python37Packages.micawber https://github.com/r-ryantm/nixpkgs/archive/cda108f9c3e661e1ca0b0cfa28eb6eb7f90f87e9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/5c81adaq04jlfiii1rda3pay67j0fh4d-python3.7-micawber-0.5.2
ls -la /nix/store/5c81adaq04jlfiii1rda3pay67j0fh4d-python3.7-micawber-0.5.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

3 packages built:
  • python37Packages.micawber
  • python38Packages.micawber
  • python39Packages.micawber

Maintainer pings

cc @davidak for testing.

Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me code-wise, looking at the r-ryantm artefacts it also looks good (and 0 package rebuild, so should be pretty safe).

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/324

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. not tested

@ryantm ryantm merged commit bd9f7e4 into NixOS:master Jan 4, 2021
@r-ryantm r-ryantm deleted the auto-update/python3.7-micawber branch January 4, 2021 07:05
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108361 run on x86_64-darwin 1

3 packages built:
  • python37Packages.micawber
  • python38Packages.micawber
  • python39Packages.micawber

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108361 run on x86_64-linux 1

3 packages failed to build and are new build failures:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants