Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kirigami2: Add qtgraphicaleffects to buildInputs #108331

Merged
merged 1 commit into from Jan 3, 2021
Merged

kirigami2: Add qtgraphicaleffects to buildInputs #108331

merged 1 commit into from Jan 3, 2021

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Jan 3, 2021 •
edited

Motivation for this change

Many of Kirigami's components require qtgraphicaleffects, so it doesn't
make sense to rely on the packages using kirigami supplying
the dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Thra11 Thra11 requested a review from ttuegel as a code owner January 3, 2021 16:47
@Thra11 Thra11 force-pushed the kirigami-qtgraphicaleffects branch from ba53ba2 to e132626 Compare January 3, 2021 16:48
@Thra11 Thra11 changed the base branch from master to staging January 3, 2021 17:23
@Thra11
kirigami2: Add qtgraphicaleffects to buildInputs
6ae1689 
Many of Kirigami's components require qtgraphicaleffects, so it doesn't
make sense to rely on the packages using kirigami supplying
the dependency.
@Thra11 Thra11 force-pushed the kirigami-qtgraphicaleffects branch from e132626 to 6ae1689 Compare January 3, 2021 17:25
ttuegel
ttuegel approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

@ttuegel ttuegel merged commit c40e1d8 into NixOS:staging Jan 3, 2021
@ttuegel
Copy link
Member

ttuegel commented Jan 3, 2021

Thanks!

@Thra11 Thra11 deleted the kirigami-qtgraphicaleffects branch January 3, 2021 20:35
@Thra11 Thra11 mentioned this pull request Jan 19, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Thra11 @ttuegel