Skip to content

pinnwand: use poetry-core instead of poetry #108318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2021
Merged

pinnwand: use poetry-core instead of poetry #108318

merged 1 commit into from
Jan 3, 2021
+10 −2

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 3, 2021

to reduce build-time closure

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@FRidh
pinnwand: use poetry-core instead of poetry

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2
Verified
Learn about vigilant mode
8c46ea4 
to reduce build-time closure
@mweinelt
Copy link
Member

mweinelt commented Jan 3, 2021

@GrahamcOfBorg test pinnwand

@ofborg ofborg bot requested a review from mweinelt January 3, 2021 13:23
@mweinelt mweinelt merged commit a319714 into NixOS:master Jan 3, 2021
@mweinelt
Copy link
Member

mweinelt commented Jan 3, 2021

Thanks!

@FRidh FRidh deleted the pinnwand branch March 13, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @mweinelt