Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nitrokey-app: 1.3.2 -> 1.4.2 #108319

Merged
merged 2 commits into from Jan 19, 2021
Merged

Conversation

KaiHa
Copy link
Contributor

@KaiHa KaiHa commented Jan 3, 2021

The option group was removed because it is no longer used in the
udev-rules that come with the libnitrokey.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jan 3, 2021

the service change and package update should be 2 separate commits.

@SuperSandro2000
Copy link
Member

@KaiHa please fix the merge conflict.

The optional argument group was removed because it is no longer used
in the udev-rules that come with the libnitrokey.
Since the update of the nitrokey-app to 1.4.2 the group option is no
longer supported.
@KaiHa
Copy link
Contributor Author

KaiHa commented Jan 18, 2021

@KaiHa please fix the merge conflict.

Done

@SuperSandro2000
Copy link
Member

@ofborg eval

1 similar comment
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108319 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
2 packages built:
  • nitrokey-app
  • nitrokey-udev-rules

@SuperSandro2000 SuperSandro2000 merged commit f591395 into NixOS:master Jan 19, 2021
@KaiHa KaiHa deleted the pr/nitrokey-app-1.4.2 branch January 26, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants