rkvm: init at ... #108288
Closed
rkvm: init at ... #108288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
force-pushed
the
rkvm
branch
2 times, most recently
from
7d221af
to
7962e35
Compare
| cargoSha256 = "sha256-1sxP74xt3DGCAhY6Dolaz2JB3Q6CTvtkgln08AMGmc0="; | ||
|
|
||
| postPatch = '' | ||
| sed -i 's|.clang_arg("-I/usr/include/libevdev-1.0/")|.clang_arg("-I${libevdev}/include/libevdev-1.0").clang_arg("-I${linuxHeaders}/include")|g' ./input/build.rs |
There was a problem hiding this comment.
Maybe we should do a patch for this because this seems quite complex.
There was a problem hiding this comment.
Hi @SuperSandro2000, thanks for looking so fast. I've left this as a draft as someones helping me in IRC. I plan to file bugs upstream, wait for them, something before marking this as ready. Or at least writing this in a slightly more readable way at least.
|
With the version I just pushed, this is the trailing result of |
Co-authored-by: Alyssa Ross <hi@alyssa.is>
|
TODO: the binaries need to be prefixed with |
|
not sure if it's working anyway: htrefil/rkvm#7 |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
@colemickens , you should probably move this into { lib
, rustPlatform
, fetchFromGitHub
, pkg-config
, libevdev
, openssl
, llvmPackages
, linuxHeaders
}:
rustPlatform.buildRustPackage rec {
pname = "rkvm";
version = "0.3.3";
src = fetchFromGitHub {
owner = "htrefil";
repo = "rkvm";
rev = version;
hash = "sha256-2cp6qtONyZHPGjLPXXEXNjyEqmqMTnvL1vKTTzg2Yek=";
};
cargoHash = "sha256-7oOJEq47Z4uKEE2BW9rR4qCETy9x89En8xJN5WjGGxA=";
nativeBuildInputs = [ llvmPackages.clang pkg-config ];
buildInputs = [ libevdev openssl linuxHeaders ];
LIBCLANG_PATH = lib.makeLibraryPath [ llvmPackages.libclang ];
# The libevdev bindings preserve comments from libev, some of which
# contain indentation which Cargo tries to interpret as doc tests.
doCheck = false;
meta = with lib; {
description = "Virtual KVM switch for Linux machines";
homepage = "https://github.com/htrefil/rkvm";
license = licenses.mit;
maintainers = with maintainers; [ colemickens ];
platforms = platforms.linux;
};
} |
stale
bot
removed
the
2.status: stale
|
I'm abandoning this. I'm happy doing everything from a single machine nowadays. If someone else wants to pick, please see @peterhoeg's comment, since I'll probably prune this branch soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #108276 by adding
rkvm.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)