laminar: 0.8 -> 1.0 #108334
laminar: 0.8 -> 1.0 #108334
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
Result of 1 package built:
|
|
Mentioning @KAction as maintainer, since that apparently hadn‘t happened automatically. |
pkgs/development/tools/continuous-integration/laminar/default.nix
Outdated
Show resolved
Hide resolved
|
It does not look to me that you can just drop "enableSystemd" option: |
|
Why not? Yes, the files are now in there. But do they do any harm? |
|
I ask "are they needed", not "do they harm". Probably even better solution would be to put it into separate output. |
|
This @maralorn @andir are you good to merge this? Aside from |
|
I think we should just remove that upstream systemd unit entirely. There is almost no point in having it in the package as the file doesn't work without spilling files into hardcoded locations (that we have to infer from the upstream unit). We should be fully declarative and just write the units ourselvs. |
Bumped version and updated javascript dependencies. Had to modify the no-network patch as well because of the changed javascript libs. Upstream changed the handling CMAKE_INSTALL_PREFIX in ohwgiles/laminar@1bb545e so I decided to patch around that as well. Removing systemd units and config file because they should be defined declaratively
|
@aanderse Thanks for picking up on this! I have decided to get rid of systemd units and the config file. Because they have no use. I also added myself as a maintainer for good measure. Is this okay for you @KAction ? Once this is merged I will approach the quest of upstreaming my laminar module. |
ofborg
bot
added
the
11.by: package-maintainer
|
Great! Thank you for your work on this.
I look forward to seeing this and the design choices you have made. |
| rm -r $out/lib # it contains only systemd unit file | ||
| ''); | ||
| rm -rf $out/lib # remove upstream systemd units | ||
| rm -rf $out/etc # remove upstream config file |
There was a problem hiding this comment.
I am find with removing the files if they provide no value. Do we have proper manpages for the configuration or is the configuration file a good example?
There was a problem hiding this comment.
That configuration file contains decent documentation for the variables, but it’s completely redundant to the man page man laminard.
|
Let's give @KAction the weekend for a reply. They are the maintainer. |
|
Yes, I am perfectly fine with what you came with. |
|
Thanks everyone! |
Bumped version and updated javascript dependencies.
Had to modify the no-network patch as well because of the changed
javascript libs.
Upstream changed the handling CMAKE_INSTALL_PREFIX in
ohwgiles/laminar@1bb545e
so I decided to patch around that as well.
@andir told me that an enableSystemd option is not necessary. The
systemd files wouldn‘t be installed without user intervention anyways.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)