Skip to content

megatools: use wrapGAppsNoGuiHook #108293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2021
Merged

megatools: use wrapGAppsNoGuiHook #108293

merged 1 commit into from
Jan 3, 2021
+2 −2

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 3, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 3, 2021
@zowoq
megatools: use wrapGAppsNoGuiHook
2445030 
The gui packages pulled in by wrapGAppsHook aren't needed as it's a cli tool.
@zowoq zowoq changed the title docs test megatools: use wrapGAppsNoGuiHook Jan 3, 2021
@zowoq zowoq marked this pull request as ready for review January 3, 2021 09:18
@zowoq zowoq removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Jan 3, 2021
@zowoq
Copy link
Contributor Author

zowoq commented Jan 3, 2021

@ofborg eval

@ofborg ofborg bot requested review from AndersonTorres and viric January 3, 2021 11:22
@AndersonTorres AndersonTorres merged commit efa604c into NixOS:master Jan 3, 2021
@zowoq zowoq deleted the docs-test branch January 3, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres

@viric viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @AndersonTorres