Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.libusb1: 1.9 -> 1.9.1 #108292

Merged
merged 1 commit into from Jan 3, 2021
Merged

pythonPackages.libusb1: 1.9 -> 1.9.1 #108292

merged 1 commit into from Jan 3, 2021

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 3, 2021

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Jan 3, 2021

@GrahamcOfBorg build python3Packages.libusb1

@prusnak prusnak merged commit 918031c into NixOS:master Jan 3, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108292 run on x86_64-darwin 1

8 packages failed to build and are new build failures:
32 packages built:
  • electrum
  • keepkey_agent (python38Packages.keepkey_agent)
  • libfx2 (python38Packages.fx2)
  • nrfutil
  • python37Packages.adb-homeassistant
  • python37Packages.adb-shell
  • python37Packages.androidtv
  • python37Packages.firetv
  • python37Packages.fx2
  • python37Packages.keepkey
  • python37Packages.keepkey_agent
  • python37Packages.libusb1
  • python37Packages.trezor
  • python37Packages.trezor_agent
  • python38Packages.adb-homeassistant
  • python38Packages.adb-shell
  • python38Packages.androidtv
  • python38Packages.firetv
  • python38Packages.keepkey
  • python38Packages.libusb1
  • python38Packages.trezor
  • trezor_agent (python38Packages.trezor_agent)
  • python39Packages.adb-homeassistant
  • python39Packages.adb-shell
  • python39Packages.androidtv
  • python39Packages.firetv
  • python39Packages.fx2
  • python39Packages.keepkey
  • python39Packages.keepkey_agent
  • python39Packages.libusb1
  • python39Packages.trezor
  • python39Packages.trezor_agent

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

keepkey_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.keepkey_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.trezor_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.keepkey_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.trezor_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
trezor_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
keepkey_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.keepkey_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.trezor_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.keepkey_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.trezor_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
trezor_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108292 run on x86_64-linux 1

4 packages failed to build and are new build failures:
36 packages built:
  • electron-cash
  • electrum
  • electrum-ltc
  • glasgow (python38Packages.glasgow)
  • keepkey_agent (python38Packages.keepkey_agent)
  • libfx2 (python38Packages.fx2)
  • nrfutil
  • python37Packages.adb-homeassistant
  • python37Packages.adb-shell
  • python37Packages.androidtv
  • python37Packages.firetv
  • python37Packages.fx2
  • python37Packages.glasgow
  • python37Packages.keepkey
  • python37Packages.keepkey_agent
  • python37Packages.libusb1
  • python37Packages.trezor
  • python37Packages.trezor_agent
  • python38Packages.adb-homeassistant
  • python38Packages.adb-shell
  • python38Packages.androidtv
  • python38Packages.firetv
  • python38Packages.keepkey
  • python38Packages.libusb1
  • python38Packages.trezor
  • trezor_agent (python38Packages.trezor_agent)
  • python39Packages.adb-homeassistant
  • python39Packages.adb-shell
  • python39Packages.androidtv
  • python39Packages.firetv
  • python39Packages.fx2
  • python39Packages.glasgow
  • python39Packages.keepkey
  • python39Packages.libusb1
  • python39Packages.trezor
  • steamcontroller

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

keepkey_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.keepkey_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.trezor_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
steamcontroller:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
trezor_agent:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member

Doing a PR tomorrow which fixes the above things.

@prusnak
Copy link
Member

prusnak commented Jan 4, 2021

  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000 Seems there is a typo how you quote doCheck = false; your script. Fix:

-* If the Packages does not contain any tests add 'doCheck = false;'`and a`pythonImportsCheck`.
+* If the Packages does not contain any tests add `doCheck = false;`and a`pythonImportsCheck`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants