Cleanup engine randomisation #8488

frosch123 · 2021-01-03T14:36:59Z

Motivation / Problem

Reading an earlier commit threw ENoSense. This tries to finish the work.

8139b14 inserted some code between a comment and the code the comment belonged to. So the comment lost any meaning.
9f42358 separated introduction-date randomisation from reliability randomisation, but only succeeded with that in 5 of 6 cases.

None

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

The bug fix is important enough to be backported? (label: 'backport requested')
This PR affects the save game format? (label 'savegame upgrade')
This PR affects the GS/AI API? (label 'needs review: Script API')
- ai_changelog.hpp, gs_changelog.hpp need updating.
- The compatibility wrappers (compat_*.nut) need updating.
This PR affects the NewGRF API? (label 'needs review: NewGRF')
- PR must be added to API tracker

…dd a comment for new code.

…f introduction date.

frosch123 added 2 commits January 3, 2021 15:05

Cleanup 8139b14: Move a comment back to the line it belongs to, and a…

65f4399

…dd a comment for new code.

Cleanup 9f42358: Make also reliability_start randomised independent o…

9a5cdda

…f introduction date.

michicc approved these changes Jan 3, 2021

View reviewed changes

LordAro approved these changes Jan 3, 2021

View reviewed changes

LordAro merged commit b08d8c7 into OpenTTD:master Jan 3, 2021