Skip to content

nixos/pam: use pam_faillock instead of pam_tally #108325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Jan 3, 2021
Merged

nixos/pam: use pam_faillock instead of pam_tally #108325

merged 1 commit into from Jan 3, 2021
+1 −1

Conversation

ghost
Copy link

@ghost ghost commented Jan 3, 2021

I'm not entirely sure if anything else needs to be done and if the functionality originally provided by pam_tally still works

Motivation for this change

Fixes #108313

#107185 removed pam_tally, in favor of pam_faillock (see release notes).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

nixos/pam: use pam_faillock instead of pam_tally
9ddd426 
Fixes #108313

\#107185 removed pam_tally, in favor of pam_faillock (see release notes).
@ghost ghost requested review from flokli, FRidh and NeQuissimus January 3, 2021 14:37
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 3, 2021
@flokli
Copy link
Contributor

flokli commented Jan 3, 2021 via email

@FRidh
Copy link
Member

FRidh commented Jan 3, 2021 •
edited
Loading

Are there are more relevant pam tests? a001d45 Those all pass.

@FRidh FRidh merged commit 018072e into NixOS:master Jan 3, 2021
@flokli
Copy link
Contributor

flokli commented Jan 3, 2021

Unfortunately, we currently don't have some that test the pam_{tally,faillock} functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli

@FRidh FRidh

@NeQuissimus NeQuissimus

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switching users doesn't work since staging merge
2 participants
@flokli @FRidh