Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad: add optional nvml support #108341

Merged
merged 1 commit into from Jan 4, 2021
Merged

nomad: add optional nvml support #108341

merged 1 commit into from Jan 4, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 3, 2021

Motivation for this change

The original version of this PR (#107030) was reverted after being
merged, because after adding nomad 1.0 the shared use of generic.nix
broke because the required arguments added in #107030 weren't being
passed in to the nomad_1_0 expression.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cpcloud cpcloud mentioned this pull request Jan 3, 2021
Closed
10 tasks
@ofborg ofborg bot requested a review from rushmorem January 3, 2021 19:37
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 3, 2021

@endocrimes @SuperSandro2000 This is effectively the same PR that was reverted but for the addition of passing the arguments to the nomad_1_0 expression.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108341 run on x86_64-linux 1

3 packages built:
  • nomad (nomad_0_12)
  • nomad_0_11
  • nomad_1_0

@SuperSandro2000 SuperSandro2000 merged commit 91e2dd2 into NixOS:master Jan 4, 2021
@marsam marsam mentioned this pull request Jan 6, 2021
Merged
10 tasks
@cpcloud cpcloud deleted the nomad-nvml branch January 16, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes Awaiting requested review from endocrimes

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpcloud @SuperSandro2000