Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildLuaPackage: pass propagatedBuildInputs to final derivation #108311

Merged
merged 1 commit into from Jan 3, 2021
Merged

buildLuaPackage: pass propagatedBuildInputs to final derivation #108311

merged 1 commit into from Jan 3, 2021

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Jan 3, 2021

Motivation for this change

propagatedBuildInputs got completely overridden in the process

cc @teto

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lblasc lblasc requested review from Shados and teto January 3, 2021 12:05
@teto
Copy link
Member

teto commented Jan 3, 2021

yes that's bad ^^'''

Completely unrelated but I've noticed neovim 0.5 crashing a lot with luajit 2.1 and enableGC64 = true;. I haven't had time to look into it and just disabled enableGC64 since the stacktrace led me to believe it was more a luajit issue. Do you know if that's a stable setting ?

@teto teto merged commit beef4b9 into NixOS:master Jan 3, 2021
@lblasc lblasc deleted the buildLuaPackage_propagatedBuildInputs branch January 3, 2021 13:04
@lblasc
Copy link
Contributor Author

lblasc commented Jan 3, 2021

@teto thx for quick response! GC64 should be stable, so far I didn't have any problems. If you can get trace please open separate issue, I'll take a look.

You can try latest luajit ( #108198 ) it has few bugfixes which are maybe related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shados Shados Awaiting requested review from Shados

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lblasc @teto