Skip to content

corerad: 0.2.8 -> 0.3.0 #108310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2021
Merged

corerad: 0.2.8 -> 0.3.0 #108310

merged 1 commit into from
Jan 3, 2021
+3 −3

Conversation

mdlayher
Copy link
Member

@mdlayher mdlayher commented Jan 3, 2021

Motivation for this change

First stable CoreRAD release!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Builds and runs, tests continue to pass:

$ ./result/bin/corerad -h
CoreRAD v0.3.0 (2021-01-03)
flags:
  -c string
        path to configuration file (default "corerad.toml")
  -init
        write out a default configuration file to "corerad.toml" and exit

/cc @jonringer @marsam @zowoq (thanks for reviews on previous PRs)

Sorry, something went wrong.

@mdlayher
corerad: 0.2.8 -> 0.3.0

Verified

This commit was signed with the committer’s verified signature.
mdlayher Matt Layher
GPG key ID: 77BFE531397EDE94
Verified
Learn about vigilant mode
680a8e7 
Signed-off-by: Matt Layher <mdlayher@gmail.com>
@mdlayher
Copy link
Member Author

mdlayher commented Jan 3, 2021

@GrahamcOfBorg test corerad

@mdlayher
Copy link
Member Author

mdlayher commented Jan 3, 2021

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 3, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Jan 3, 2021
@mdlayher
Copy link
Member Author

mdlayher commented Jan 3, 2021

/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the needs_reviewer (old Marvin label, do not use) label Jan 3, 2021
@marvin-mk2 marvin-mk2 bot requested a review from kevincox January 3, 2021 12:05
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Jan 3, 2021
@ofborg ofborg bot requested a review from kalbasit January 3, 2021 12:13
hugolgst
hugolgst approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 108310

1 package built:
corerad

@prusnak prusnak merged commit 712830d into NixOS:master Jan 3, 2021
@mdlayher mdlayher deleted the mdl-bump-corerad branch January 3, 2021 12:34
@mdlayher mdlayher restored the mdl-bump-corerad branch January 3, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst

@kevincox kevincox

@kalbasit kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdlayher @hugolgst @prusnak