Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.aiosqlite: 0.12.0 -> 0.16.0 #108308

Closed
wants to merge 1 commit into from
Closed

python3Packages.aiosqlite: 0.12.0 -> 0.16.0 #108308

wants to merge 1 commit into from

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 3, 2021

Motivation for this change

Bump to latest upstream release 0.16.0

Upstream switched to poetry thus the switch to the PyPI release.

Change log: https://github.com/omnilib/aiosqlite/blob/main/CHANGELOG.md#v0160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc January 3, 2021 12:01
SuperSandro2000
SuperSandro2000 requested changes Jan 3, 2021
View reviewed changes
pkgs/development/python-modules/aiosqlite/default.nix
];

# tests are not pick-up automatically by the hook
pytestFlagsArray = [ "aiosqlite/tests/*.py" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try:

preTest = ''
  cd aiosqlite
'';

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 4, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108308 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python39Packages.databases
  • python39Packages.fastapi
  • python39Packages.orm
  • python39Packages.starlette
6 packages failed to build and are new build failures:
5 packages built:
  • python37Packages.aiosqlite
  • python37Packages.databases
  • python38Packages.aiosqlite
  • python38Packages.databases
  • python39Packages.aiosqlite

Build failures are fixed by me already and are unrelated to this PR.

@mweinelt mweinelt mentioned this pull request Jan 6, 2021
Merged
10 tasks
@fabaff
Copy link
Member Author

fabaff commented Jan 6, 2021

Closing this PR as #108602 also contains the update to 0.16.0.

@fabaff fabaff closed this Jan 6, 2021
@fabaff fabaff deleted the bump-aiosqlite branch January 6, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @SuperSandro2000