Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdf4: Fix aarch64 build #108347

Merged
merged 1 commit into from Jan 4, 2021
Merged

hdf4: Fix aarch64 build #108347

merged 1 commit into from Jan 4, 2021

Conversation

knedlsepp
Copy link
Member

Motivation for this change

The last glibc bump did break the aarch64 build of hdf4. We fix it by
adding the libtirpc dependency, which was previously part of glibc.

Fixes: #108340

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp marked this pull request as draft January 3, 2021 21:06
@knedlsepp
Copy link
Member Author

I only built this on my x86_64 machine guessing that this will just work.
After spinning up my raspberry-pi it turns out that this actually isn't enough.

@knedlsepp
hdf4: Fix aarch64 build
c1a2918 
The last glibc bump did break the aarch64 build of hdf4. We fix it by
adding the libtirpc dependency, which was previously part of glibc.

Fixes: NixOS#108340
@knedlsepp knedlsepp marked this pull request as ready for review January 3, 2021 21:44
@knedlsepp
Copy link
Member Author

After pulling some patches from Fedora, this seems to build fine now.

@Thra11 Thra11 mentioned this pull request Jan 3, 2021
Merged
10 tasks
@FRidh FRidh merged commit 311adde into NixOS:master Jan 4, 2021
@purcell purcell mentioned this pull request Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gdal is broken because optional dependency hdf4 is broken
2 participants
@knedlsepp @FRidh