Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-download: Fix build by bumping url from 1.6.0 to 1.6.1 #108283

Merged
merged 1 commit into from Jan 3, 2021
Merged

cargo-download: Fix build by bumping url from 1.6.0 to 1.6.1 #108283

merged 1 commit into from Jan 3, 2021

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jan 3, 2021 •
edited

Motivation for this change

url 1.6.0 no longer builds with Rust 1.40 and later due to a lifetime bug uncovered by NLL (Xion/cargo-download#7).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
cargo-download: Fix build by bumping url from 1.6.0 to 1.6.1
74a8ac4 
url 1.6.0 no longer builds with Rust 1.40 and later due to a lifetime
bug uncovered by NLL: Xion/cargo-download#7

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk requested a review from globin January 3, 2021 04:15
@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 108283 run on x86_64-linux 1

1 package built:
  • cargo-download

@lovesegfault lovesegfault merged commit aabff59 into NixOS:master Jan 3, 2021
@andersk andersk deleted the cargo-download branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersk @lovesegfault